Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting issues #3838

Merged
merged 2 commits into from
Mar 24, 2018
Merged

Fix linting issues #3838

merged 2 commits into from
Mar 24, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 23, 2018

No description provided.

davidfischer
davidfischer approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Some of this might be better written as a combination of any and all.

@agjohnson agjohnson merged commit 7b8efe3 into master Mar 24, 2018
@agjohnson agjohnson deleted the humitos/lint/fixes branch March 24, 2018 07:14
@agjohnson
Copy link
Contributor

I also would prefer any/all here, but this is fine for now! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfischer davidfischer davidfischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humitos @agjohnson @davidfischer